[PATCH] D45719: [clang-Format] Fix indentation of member call after block

This revision was automatically updated to reflect the committed changes. Closed by commit rC342363: [clang-Format] Fix indentation of member call after block (authored by ibiryukov, committed by ). Repository: rC Clang https://reviews.llvm.org/D45719 Files:

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ilya-biryukov added a comment. Landed the patch as r342363. Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. ping @klimek Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. Ping! it would be awesome to get some help getting this merged since I do not have merge rights Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank updated this revision to Diff 158737. ank added a comment. fix space in if ( Repository: rC Clang https://reviews.llvm.org/D45719 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

danilaml added inline comments. Comment at: lib/Format/FormatToken.h:323 + bool closesScopeAfterBlock() const { +if(BlockKind == BK_Block) + return true; Looks like all other `if`s in this file have space before `(`. Repository: rC Clang

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

klimek added a comment. Sorry that I lost track of that, but feel free to ping once / week - unfortunately the patch doesn't apply cleanly, can you rebase? Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. Herald added a subscriber: acoomans. Ping! it would be awesome to get some help getting this merged since I do not have merge rights Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. awesome, I do not have merge rights so help with merging this would be greatly appreciated Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG. Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank updated this revision to Diff 152870. Repository: rC Clang https://reviews.llvm.org/D45719 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added inline comments. Comment at: unittests/Format/FormatTest.cpp:4449-4450 + " })\n" + " .foo(\"aaa\"\n" + " \"bb\");\n" +

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

klimek added inline comments. Comment at: unittests/Format/FormatTest.cpp:4449-4450 + " })\n" + " .foo(\"aaa\"\n" + " \"bb\");\n" +

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added inline comments. Comment at: unittests/Format/FormatTest.cpp:4359 + "return 3;\n" + " }).as("");\n" + "}"); klimek wrote: > ank wrote: > > klimek wrote: > > > ank wrote: > > > > klimek wrote: > > > > >

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank updated this revision to Diff 152842. Repository: rC Clang https://reviews.llvm.org/D45719 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

klimek added inline comments. Comment at: unittests/Format/FormatTest.cpp:4359 + "return 3;\n" + " }).as("");\n" + "}"); ank wrote: > klimek wrote: > > ank wrote: > > > klimek wrote: > > > > What would be

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added inline comments. Comment at: unittests/Format/FormatTest.cpp:4359 + "return 3;\n" + " }).as("");\n" + "}"); klimek wrote: > ank wrote: > > klimek wrote: > > > What would be interesting is tests that: > > >

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

klimek added inline comments. Comment at: unittests/Format/FormatTest.cpp:4359 + "return 3;\n" + " }).as("");\n" + "}"); ank wrote: > klimek wrote: > > What would be interesting is tests that: > > a) have another

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. Is there any chance to get this change or a similar one in so we get same behaviour as in release_40, even though it does not correct all of the problems? Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added inline comments. Comment at: unittests/Format/FormatTest.cpp:4359 + "return 3;\n" + " }).as("");\n" + "}"); klimek wrote: > What would be interesting is tests that: > a) have another value after the

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

klimek added inline comments. Comment at: unittests/Format/FormatTest.cpp:4359 + "return 3;\n" + " }).as("");\n" + "}"); What would be interesting is tests that: a) have another value after the closing }; doesn't

[PATCH] D45719: [clang-Format] Fix indentation of member call after block

ank added a comment. ping Repository: rC Clang https://reviews.llvm.org/D45719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits