[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

2018-04-17 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL330225: Add Microsoft mangling for _Float16 (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D45738?vs=142827=142846#toc Repository: rL LLVM

[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

2018-04-17 Thread David Majnemer via Phabricator via cfe-commits
majnemer accepted this revision. majnemer added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D45738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

2018-04-17 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. FWIW, this demangles on both demangler.com and undname as "void __cdecl Float16::f(struct __clang::_Float16)", which seems like the right thing, since the "Complex" above demangles to: "void __cdecl Complex::f(struct __clang::_Complex)" I also note (since upon

[PATCH] D45738: Add Microsoft mangling for _Float16, similar to technique used for _Complex

2018-04-17 Thread Melanie Blower via Phabricator via cfe-commits
mibintc created this revision. mibintc added reviewers: erichkeane, cfe-commits, majnemer. Herald added a subscriber: llvm-commits. Microsoft doesn't support _Float16, so this patch invents a mangling using the technique that was used for _Complex, putting _Float16 into __clang namespace. What