aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Committed in r331598, with an additional test case.
(Accepting officially on behalf of @rjmccall so that I can close the review.)
https://reviews.llvm.org/D45944
rjmccall added a comment.
LGTM, although you might consider testing a broader set of builtins. Maybe at
least one from the `__atomic_*` family?
https://reviews.llvm.org/D45944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added reviewers: rjmccall, efriedma.
aaron.ballman added a comment.
Adding a few more potential reviewers.
https://reviews.llvm.org/D45944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman added a comment.
Ping
https://reviews.llvm.org/D45944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In https://reviews.llvm.org/D45944#1075055, @lebedev.ri wrote:
> Please always upload all patches with full context (`-U9`)
I'm not keen on uploading patches with that much context. For instance, it
disables syntax highlighting in Phab for many of our files.
aaron.ballman updated this revision to Diff 143526.
aaron.ballman added a comment.
Updated with more context.
https://reviews.llvm.org/D45944
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaChecking.cpp
test/Sema/builtins.c
Index: test/Sema/builtins.c
lebedev.ri added a comment.
Please always upload all patches with full context (`-U9`)
https://reviews.llvm.org/D45944
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman created this revision.
aaron.ballman added reviewers: rsmith, dblaikie.
The following code is currently accepted without a diagnostic when it should be
prohibited:
void f(const int *ptr) {
__sync_fetch_and_add(ptr, 1);
}
NB: the above code is diagnosed by GCC and ICC.
