[PATCH] D46139: Add template type and value parameter metadata nodes to template variable specializations.

2018-04-26 Thread Matthew Voss via Phabricator via cfe-commits
ormris abandoned this revision. ormris added a comment. After some further inspection, support for the LLVM side of patch needs a few significant additions. Abandoning this revision. Repository: rC Clang https://reviews.llvm.org/D46139 ___ cfe-c

[PATCH] D46139: Add template type and value parameter metadata nodes to template variable specializations.

2018-04-26 Thread Matthew Voss via Phabricator via cfe-commits
ormris added a comment. Thanks for spotting that @probinson. Will update. Repository: rC Clang https://reviews.llvm.org/D46139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46139: Add template type and value parameter metadata nodes to template variable specializations.

2018-04-26 Thread Paul Robinson via Phabricator via cfe-commits
probinson added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:3023 + templateParameters = parameterNodes.get(); + // Since we emit declarations (DW_AT_members) for static members, place the Naively it looks like it should be possible to put the loc

[PATCH] D46139: Add template type and value parameter metadata nodes to template variable specializations.

2018-04-26 Thread Matthew Voss via Phabricator via cfe-commits
ormris created this revision. ormris added reviewers: dblaikie, probinson, aprantl, JDevlieghere, clayborg. Depends on LLVM patch: https://reviews.llvm.org/D46138 Resolves PR22119 Repository: rC Clang https://reviews.llvm.org/D46139 Files: lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGDebug