[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D46190#1135295, @probinson wrote: > Style comments. > The two new Sema methods (for namespaces and using references) are C++ > specific, so SemaDeclCXX.cpp would seem like a more appropriate home for them. Both functions have

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D46190#1135688, @rsmith wrote: > The right way to handle this is to pass both the ultimately-selected > declaration and the declaration found by name lookup into the calls to > `MarkAnyDeclReferenced` and friends. We should mark

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. rsmith Thanks very much for your review. I will address them. https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. @probinson Thanks very much for your review. I will address them. https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

rsmith added a comment. The right way to handle this is to pass both the ultimately-selected declaration and the declaration found by name lookup into the calls to `MarkAnyDeclReferenced` and friends. We should mark the selected declaration as `Used` (when appropriate), and mark the found

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

probinson added a comment. Style comments. The two new Sema methods (for namespaces and using references) are C++ specific, so SemaDeclCXX.cpp would seem like a more appropriate home for them. Comment at: lib/Sema/Sema.cpp:1879 +void

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

probinson added a comment. @dblaikie is @rsmith back from the standards meeting yet? I hate to be a pest but this is blocking other work Carlos has in progress. https://reviews.llvm.org/D46190 ___ cfe-commits mailing list

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. Ping. The review https://reviews.llvm.org/D44826 is already approved and it is dependent on this patch being reviewed. @rsmith Is there anything I can add to this patch? Thanks https://reviews.llvm.org/D46190

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

probinson added a comment. @rsmith anything else needed here? https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. Ping. The review https://reviews.llvm.org/D44826 is already approved and it is dependent on this patch being reviewed. Is there anything I can add to this patch? Thanks very much. https://reviews.llvm.org/D46190

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. Ping. Thanks https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso added a comment. Ping. Thanks https://reviews.llvm.org/D46190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46190: For a referenced declaration, mark any associated usings as referenced.

CarlosAlbertoEnciso updated this revision to Diff 147050. CarlosAlbertoEnciso edited the summary of this revision. CarlosAlbertoEnciso added a comment. Address the issues raised by the reviewer (rsmith). https://reviews.llvm.org/D46190 Files: include/clang/Sema/Sema.h lib/Sema/Sema.cpp