This revision was automatically updated to reflect the committed changes.
Closed by commit rC331504: [Driver] Don't warn about unused inputs in
config files (authored by mstorsjo, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D46286
Files:
lib/Driver/Driver.cpp
test/Driver
sepavloff accepted this revision.
sepavloff added a comment.
With additional changes the fix is OK.
LGTM.
https://reviews.llvm.org/D46286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
mstorsjo added a comment.
@sepavloff - does the additional change to this one also look fine to you?
https://reviews.llvm.org/D46286
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mstorsjo updated this revision to Diff 144839.
mstorsjo added a comment.
In order not to break test/Driver/cl-pch.cpp (I hadn't run the full testsuite
for this change before submitting the patch), I had to do another tweak, in
order not to claim any input argument after `--`. Does it still sound
sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.
Indeed, this is a missing case. Thank you for fixing it!
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D46286
___
cfe-commits mail
mstorsjo created this revision.
mstorsjo added reviewers: sepavloff, hans, rnk, hfinkel.
This avoids warnings about unused linker parameters, just like other flags are
ignored if they're from config files.
Repository:
rC Clang
https://reviews.llvm.org/D46286
Files:
lib/Driver/Driver.cpp
