[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-30 Thread Louis Dionne via Phabricator via cfe-commits
ldionne requested changes to this revision. ldionne added a comment. Trying to summarize the discussion here for the author: 1. Please add a `` header to libc++ that does `#include_next ` and then defines both `__alignof_is_defined` and `__alignas_is_defined`. 2. Please re-add a test checking

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-10 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + sbc100 wrote: > hubert.reinterpretcast wrote: > > curdeius wrote: > > > hubert.reinterpretcast wrote: > > > > curdeius wrote: > > > > >

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-10 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > curdeius wrote: > > hubert.reinterpretcast wrote: > > > curdeius wrote: > > > > curdeius wrote: > > > > >

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-10 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > hubert.reinterpretcast wrote: > > curdeius wrote: > > > curdeius wrote: > > > > hubert.reinterpretcast wrote: > > > > >

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-10 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius requested changes to this revision. curdeius added inline comments. This revision now requires changes to proceed. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > curdeius wrote: > > curdeius

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-09 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > curdeius wrote: > > hubert.reinterpretcast wrote: > > > sbc100 wrote: > > > > hubert.reinterpretcast wrote: > > > > > This

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-09 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + curdeius wrote: > hubert.reinterpretcast wrote: > > sbc100 wrote: > > > hubert.reinterpretcast wrote: > > > > This seems to be assuming that the underlying

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-09 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > sbc100 wrote: > > hubert.reinterpretcast wrote: > > > This seems to be assuming that the underlying C library's `stdalign.h`

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-06 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + sbc100 wrote: > hubert.reinterpretcast wrote: > > This seems to be assuming that the underlying C library's `stdalign.h` is > > C++ friendly.

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-06 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + hubert.reinterpretcast wrote: > This seems to be assuming that the underlying C library's `stdalign.h` is C++ > friendly. A C11 `stdalign.h` //does// define

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-05 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: libcxx/include/cstdalign:24 +#include <__config> +#include + This seems to be assuming that the underlying C library's `stdalign.h` is C++ friendly. A C11 `stdalign.h` //does// define `alignof` and

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-05 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Please wait for CI to finish! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D46443/new/ https://reviews.llvm.org/D46443

[PATCH] D46443: [libc++] Add missing cstdalign header

2021-03-05 Thread Marek Kurdej via Phabricator via cfe-commits
curdeius accepted this revision as: curdeius. curdeius added a comment. LGTM but please wait for libc++ group approval. If you need someone to land it for you, please provide "Firstname Name " for attribution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION