ldionne requested changes to this revision.
ldionne added a comment.
Trying to summarize the discussion here for the author:
1. Please add a `` header to libc++ that does `#include_next
` and then defines both `__alignof_is_defined` and
`__alignas_is_defined`.
2. Please re-add a test checking
hubert.reinterpretcast added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
sbc100 wrote:
> hubert.reinterpretcast wrote:
> > curdeius wrote:
> > > hubert.reinterpretcast wrote:
> > > > curdeius wrote:
> > > > >
sbc100 added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
hubert.reinterpretcast wrote:
> curdeius wrote:
> > hubert.reinterpretcast wrote:
> > > curdeius wrote:
> > > > curdeius wrote:
> > > > >
hubert.reinterpretcast added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
curdeius wrote:
> hubert.reinterpretcast wrote:
> > curdeius wrote:
> > > curdeius wrote:
> > > > hubert.reinterpretcast wrote:
> > > > >
curdeius requested changes to this revision.
curdeius added inline comments.
This revision now requires changes to proceed.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
hubert.reinterpretcast wrote:
> curdeius wrote:
> > curdeius
hubert.reinterpretcast added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
curdeius wrote:
> curdeius wrote:
> > hubert.reinterpretcast wrote:
> > > sbc100 wrote:
> > > > hubert.reinterpretcast wrote:
> > > > > This
curdeius added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
curdeius wrote:
> hubert.reinterpretcast wrote:
> > sbc100 wrote:
> > > hubert.reinterpretcast wrote:
> > > > This seems to be assuming that the underlying
curdeius added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
hubert.reinterpretcast wrote:
> sbc100 wrote:
> > hubert.reinterpretcast wrote:
> > > This seems to be assuming that the underlying C library's `stdalign.h`
hubert.reinterpretcast added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
sbc100 wrote:
> hubert.reinterpretcast wrote:
> > This seems to be assuming that the underlying C library's `stdalign.h` is
> > C++ friendly.
sbc100 added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
hubert.reinterpretcast wrote:
> This seems to be assuming that the underlying C library's `stdalign.h` is C++
> friendly. A C11 `stdalign.h` //does// define
hubert.reinterpretcast added inline comments.
Comment at: libcxx/include/cstdalign:24
+#include <__config>
+#include
+
This seems to be assuming that the underlying C library's `stdalign.h` is C++
friendly. A C11 `stdalign.h` //does// define `alignof` and
ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.
Please wait for CI to finish!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D46443/new/
https://reviews.llvm.org/D46443
curdeius accepted this revision as: curdeius.
curdeius added a comment.
LGTM but please wait for libc++ group approval.
If you need someone to land it for you, please provide "Firstname Name
" for attribution.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
13 matches
Mail list logo