This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE332363: [clangd] Populate #include insertions as
additional edits in completion items. (authored by ioeric, committed by ).
Changed prior to commit:
ioeric updated this revision to Diff 146843.
ioeric added a comment.
- Merged with origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdServer.cpp
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Headers.cpp
clangd/Headers.h
ioeric updated this revision to Diff 146839.
ioeric added a comment.
- Rebase...
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdServer.cpp
clangd/CodeComplete.cpp
clangd/CodeComplete.h
clangd/Headers.cpp
clangd/Headers.h
clangd/Protocol.h
ioeric updated this revision to Diff 146838.
ioeric added a comment.
- Rebase on https://reviews.llvm.org/D46676
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/CodeComplete.cpp
ioeric updated this revision to Diff 146834.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice, ship it!
Comment at: clangd/CodeComplete.cpp:317
+if (Includes && !D->IncludeHeader.empty()) {
+ // Fallback to canonical header if declaration
ioeric updated this revision to Diff 146675.
ioeric marked 7 inline comments as done.
ioeric added a comment.
- Addressed review comments.
- Merged with origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdServer.cpp
sammccall added inline comments.
Comment at: clangd/CodeComplete.cpp:247
+// Calculates include path and insertion edit for a new header.
+class IncludeInserter {
+public:
Do you think it would make sense to move this class to Headers.h? This would
reduce the
ioeric added a comment.
This has been split and now depends on https://reviews.llvm.org/D46670,
https://reviews.llvm.org/D46675, https://reviews.llvm.org/D46676.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
___
cfe-commits
ioeric updated this revision to Diff 146083.
ioeric added a comment.
- Rebase on https://reviews.llvm.org/D46670, https://reviews.llvm.org/D46675,
https://reviews.llvm.org/D46676
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdServer.cpp
ioeric updated this revision to Diff 146046.
ioeric added a comment.
- Minor cleanup
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdServer.cpp
clangd/ClangdServer.h
clangd/ClangdUnit.cpp
clangd/ClangdUnit.h
ioeric added a comment.
In https://reviews.llvm.org/D46497#1089755, @sammccall wrote:
> I'm concerned about the scope of this patch - it does too many things and
> touches too many files for me to feel comfortable that I understand it well
> enough to review.
> Is it possible to split it up?
ioeric updated this revision to Diff 146045.
ioeric marked 15 inline comments as done.
ioeric added a comment.
- Merged with origin/master
- Address review comments.
- Revert unintended change.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46497
Files:
sammccall added a comment.
I'm concerned about the scope of this patch - it does too many things and
touches too many files for me to feel comfortable that I understand it well
enough to review.
Is it possible to split it up? (You mention 6 distinct things in the
description).
Have tried to
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov, klimek.
o Remove IncludeInsertion LSP command.
o Populate include insertion edits synchromously in completion items.
o Share the code completion compiler
15 matches
Mail list logo
