[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

rnk added a comment. In https://reviews.llvm.org/D46520#1092681, @mstorsjo wrote: > Reverted in SVN r331858. Thanks! When one attempts to generate pre-processed source with clang and compile it with MSVC, you usually have to remove clang's internal intrinsic headers from the include search

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

mstorsjo closed this revision. mstorsjo added a comment. Reverted in SVN r331858. Repository: rL LLVM https://reviews.llvm.org/D46520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

hans added a comment. In https://reviews.llvm.org/D46520#1092233, @rnk wrote: > Please don't do this, this is actually really problematic, since `#line` > directives lose information about what's a system header. That means the > result of -E usually won't compile, since Windows headers are

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

mstorsjo added a comment. In https://reviews.llvm.org/D46520#1092233, @rnk wrote: > Please don't do this, this is actually really problematic, since `#line` > directives lose information about what's a system header. That means the > result of -E usually won't compile, since Windows headers

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

rnk reopened this revision. rnk added a comment. This revision is now accepted and ready to land. Please don't do this, this is actually really problematic, since `#line` directives lose information about what's a system header. That means the result of -E usually won't compile, since Windows

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

This revision was automatically updated to reflect the committed changes. Closed by commit rL331666: [Driver] Use -fuse-line-directives by default in MSVC mode (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC331666: [Driver] Use -fuse-line-directives by default in MSVC mode (authored by mstorsjo, committed by ). Changed prior to commit: https://reviews.llvm.org/D46520?vs=145446=145528#toc Repository: rC

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

mstorsjo added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4218 // -fno-use-line-directives is default. if (Args.hasFlag(options::OPT_fuse_line_directives, hans wrote: > The comment needs an update I think. Thanks, will change into

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Seems reasonable to me (but please update the comment before landing). Comment at: lib/Driver/ToolChains/Clang.cpp:4218 // -fno-use-line-directives is default. if

[PATCH] D46520: [Driver] Use -fuse-line-directives by default in MSVC mode

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, thakis. Don't use the GNU extension form of line markers in MSVC mode. Repository: rC Clang https://reviews.llvm.org/D46520 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/cl-options.c Index: