[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

This revision was automatically updated to reflect the committed changes. Closed by commit rL332598: Use dotted format of version tuple for availability diagnostics (authored by jkorous, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

erik.pilkington accepted this revision. erik.pilkington added a comment. Great, LGTM! https://reviews.llvm.org/D46747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous updated this revision to Diff 147184. jkorous added a comment. This revision is now accepted and ready to land. After some internal discussion we agreed that we can simplify things and get consistent behaviour by using dot everywhere in diagnostics. This is pretty much revert of r219124

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous added a comment. Eric, thanks for the context. I am now clarifying internally and if possible would like to simplify the whole format business by using just one delimiter everywhere. Would that make sense to you or do you think we should respect delimiter used in sources?

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

erik.pilkington added a comment. > I am now thinking about just switching to dot format in > ParseAvailabilityAttribute() because it's much simpler to maintain > consistency that way. Okay, but if we're going to treat underscores as dots while printing diagnostics and fixits (which I think we

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous planned changes to this revision. jkorous added a comment. Sorry for me being dense here - since the output format is determined by input source code there's more work to do. I tried to change format of introduced version in couple of tests and the output mirrors the change. That

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. Thanks for the explanation, LGTM. https://reviews.llvm.org/D46747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous added a comment. I am not 100% sure it's the best thing to set printing style at the point of parsing version tuples but I am not sure it's bad either. Unless someone convinces me otherwise I would rather not do any major changes. https://reviews.llvm.org/D46747

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous updated this revision to Diff 146605. jkorous added a comment. Fixed the test. It turned out that version component separator for availability is set during parsing which is why all other tests (including my bad one) are passing. The only way how to set underscore as a separator is

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous planned changes to this revision. jkorous added a comment. Sorry, my bad. I tried to get rid of dependency on Foundation.h and didn't check the test is relevant for the fix after that. #import @interface foo - (void) method NS_AVAILABLE_MAC(10_12); @end int main() {

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

erik.pilkington added a comment. That test passes for me without this patch applied, why is UsesUnderscores actually getting set in the radar? Repository: rC Clang https://reviews.llvm.org/D46747 ___ cfe-commits mailing list

[PATCH] D46747: [Sema] Use dotted form of macOS version for unguarded availability FixIts

jkorous created this revision. jkorous added reviewers: arphaman, erik.pilkington, vsapsai. jkorous added a project: clang. Herald added a subscriber: cfe-commits. E. g. use "10.11" instead of "10_11". This is just a consistency fix - the dotted format is already used everywhere else.