This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE332226: [clangd] Dont query index when completing
inside classes (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46795?vs=146571=146574#toc
Repository:
ilya-biryukov added inline comments.
Comment at: unittests/clangd/CodeCompleteTests.cpp:829
+TEST(CompletionTest, NoIndexCompletionsInsideClasses) {
+ // clang-format off
+ auto Completions = completions(R"cpp(
sammccall wrote:
> Can we avoid disabling
ilya-biryukov updated this revision to Diff 146571.
ilya-biryukov marked 5 inline comments as done.
ilya-biryukov added a comment.
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D46795
Files:
clangd/CodeComplete.cpp
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/CodeComplete.cpp:810
+return false;
+ auto Scope = CC.getCXXScopeSpecifier();
+ if (!Scope)
we could use a high level
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sammccall, ioeric.
Herald added subscribers: jkorous, MaskRay, klimek.
We used to query the index when completing after class qualifiers,
e.g. 'ClassName::^'. We should not do that for the same reasons we
don't query the index
