This revision was automatically updated to reflect the committed changes.
Closed by commit rC333166: [ASTImporter] Add unit tests for structural
equivalence (authored by martong, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D46867?vs=148352=148353#toc
Repository:
rC
martong updated this revision to Diff 148352.
martong added a comment.
Moved `using std::get` up, before `testStructuralMatch`.
Repository:
rC Clang
https://reviews.llvm.org/D46867
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/CMakeLists.txt
unittests/AST/Language.cpp
a.sidorin accepted this revision.
a.sidorin added a comment.
This revision is now accepted and ready to land.
Hi Gabor,
LGTM, thank you for addressing the comments! Just a minor nit, it's OK to fix
it before committing without a separate review.
Comment at:
martong updated this revision to Diff 147304.
martong marked an inline comment as done.
martong added a comment.
- Address aleksei's comments
Repository:
rC Clang
https://reviews.llvm.org/D46867
Files:
unittests/AST/ASTImporterTest.cpp
unittests/AST/CMakeLists.txt
martong marked 14 inline comments as done.
martong added a comment.
> Do you plan to enable this functionality for AST import checking?
Yes. We'd like to test the structural equivalency independently from
ASTImporter, because in certain cases it may have faulty behavior. This can be
very handy
a.sidorin added a comment.
Hello Gabor!
Thank you for this patch! Do you plan to enable this functionality for AST
import checking?
Some comments are inline.
Comment at: unittests/AST/Language.h:1
+//===- unittest/AST/Language.h - AST unit test support ---===//
martong created this revision.
martong added reviewers: a.sidorin, xazax.hun, szepet.
Herald added subscribers: cfe-commits, dkrupp, rnkovacs, mgorny.
This patch add new tests for structural equivalence. For that a new common
header is created which holds the test related language specific types
