[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

2018-05-17 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris added a comment. In https://reviews.llvm.org/D46998#1103397, @dblaikie wrote: > "In the future we can revisit this when we have a better idea as to why not > depending on the C++ ABI functionality is a better solution." - this was > discussed previously in the thread linked from the

[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

2018-05-17 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. "In the future we can revisit this when we have a better idea as to why not depending on the C++ ABI functionality is a better solution." - this was discussed previously in the thread linked from the bug. A big thing, so far as I understand it, is that Clang doesn't

[PATCH] D46998: [XRay][clang+compiler-rt] Make XRay depend on a C++ standard lib

2018-05-17 Thread Dean Michael Berris via Phabricator via cfe-commits
dberris created this revision. dberris added reviewers: dblaikie, echristo. This is related to http://llvm.org/PR32274. When building with XRay, always depend on a C++ standard library. We're doing this to automate the linking of the C++ ABI functionality that the modes use by default. In