This revision was automatically updated to reflect the committed changes.
Prazek marked an inline comment as done.
Closed by commit rL336073: Implement strip.invariant.group (authored by Prazek,
committed by ).
Changed prior to commit:
https://reviews.llvm.org/D47103?vs=148313=153664#toc
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: llvm/docs/LangRef.rst:12928
+established by ``invariant.group`` metadata no longer holds, to obtain a new
pointer
+value that does carries fresh invariant
Prazek added a comment.
Friendly ping @hfinkel @rsmith
Repository:
rL LLVM
https://reviews.llvm.org/D47103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a comment.
friendly ping
Repository:
rL LLVM
https://reviews.llvm.org/D47103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:3858
+}
+ }
+
Prazek wrote:
> rjmccall wrote:
> > Please add a comment explaining why this is necessary. (I'm actually not
> > sure why it is, because surely the invariant groups we
Prazek updated this revision to Diff 148313.
Prazek marked 2 inline comments as done.
Prazek added a comment.
Slitted commit into defining and using intrinsic
Repository:
rL LLVM
https://reviews.llvm.org/D47103
Files:
llvm/docs/LangRef.rst
llvm/include/llvm/IR/IRBuilder.h
Prazek added inline comments.
Comment at: clang/lib/CodeGen/CGExpr.cpp:3858
+}
+ }
+
rjmccall wrote:
> Please add a comment explaining why this is necessary. (I'm actually not
> sure why it is, because surely the invariant groups we generate don't contain
rjmccall added a comment.
The changes to Clang generally seem reasonable, but I think you should split
them into a separate commit from the commit that adds the intrinsic itself.
Comment at: clang/lib/CodeGen/CGExpr.cpp:3858
+}
+ }
+
Please add a comment
amharc added inline comments.
Comment at: clang/include/clang/AST/DeclCXX.h:778
+ bool mayBeDynamicClass() const {
+return !isCompleteDefinition() || isDynamicClass();
xbolva00 wrote:
> maybeDynamicClass?
>
>
Prazek updated this revision to Diff 147691.
Prazek added a comment.
rebase
Repository:
rL LLVM
https://reviews.llvm.org/D47103
Files:
clang/include/clang/AST/DeclCXX.h
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGExprScalar.cpp
clang/test/CodeGenCXX/strict-vtable-pointers.cpp
Prazek updated this revision to Diff 147688.
Prazek added a comment.
After rebasing
Repository:
rL LLVM
https://reviews.llvm.org/D47103
Files:
clang/include/clang/AST/DeclCXX.h
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGExprScalar.cpp
Prazek updated this revision to Diff 147684.
Prazek added a comment.
Changed comments
Repository:
rL LLVM
https://reviews.llvm.org/D47103
Files:
clang/include/clang/AST/DeclCXX.h
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGExprScalar.cpp
xbolva00 added inline comments.
Comment at: clang/include/clang/AST/DeclCXX.h:778
+ bool mayBeDynamicClass() const {
+return !isCompleteDefinition() || isDynamicClass();
maybeDynamicClass?
https://github.com/llvm-mirror/llvm/search?utf8=%E2%9C%93=maybe=
Prazek updated this revision to Diff 147683.
Prazek added a comment.
introduced mayBeDynamicClass and added more tests
Repository:
rL LLVM
https://reviews.llvm.org/D47103
Files:
clang/include/clang/AST/DeclCXX.h
clang/lib/CodeGen/CGExpr.cpp
clang/lib/CodeGen/CGExprScalar.cpp
14 matches
Mail list logo
