This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
Closed by commit rL11: [DebugInfo] Don't bother with MD5 checksums of
preprocessed files. (authored by probinson, committed by ).
Herald added a subscriber: llvm-commits.
Chan
This revision was automatically updated to reflect the committed changes.
probinson marked an inline comment as done.
Closed by commit rC11: [DebugInfo] Don't bother with MD5 checksums of
preprocessed files. (authored by probinson, committed by ).
Changed prior to commit:
https://reviews.ll
probinson marked an inline comment as done.
probinson added inline comments.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:378
return None;
+ if (Entry.getFile().hasLineDirectives()) {
+EmitFileChecksums = false;
aprantl wrote:
> Can you add a comment e
aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.
Minor comment inline.
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:378
return None;
+ if (Entry.getFile().hasLineDirectives()) {
+EmitFileChecksums = false;
probinson updated this revision to Diff 148663.
probinson added a comment.
Upload patch to suppress checksums when we see a preprocessed file.
https://reviews.llvm.org/D47260
Files:
clang/lib/CodeGen/CGDebugInfo.cpp
clang/lib/CodeGen/CGDebugInfo.h
clang/test/CodeGen/md5-checksum-crash.c
