This revision was automatically updated to reflect the committed changes.
Closed by commit rL335393: [Sema] -Wformat-pedantic only for
NSInteger/NSUInteger %zu/%zi on Darwin (authored by jfb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/
arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for working on this!
Repository:
rC Clang
https://reviews.llvm.org/D47290
___
cfe-commits mailing list
cfe-commits@lists.llvm
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1127190, @jfb wrote:
> In https://reviews.llvm.org/D47290#1126443, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47290#1125028, @aaron.ballman wrote:
> >
> > > Okay, that's fair, but the vendor-specific type for my Windo
jfb added a comment.
In https://reviews.llvm.org/D47290#1126443, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1125028, @aaron.ballman wrote:
>
> > Okay, that's fair, but the vendor-specific type for my Windows example is
> > spelled `DWORD`. I'm really worried that this special cas
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1125028, @aaron.ballman wrote:
> Okay, that's fair, but the vendor-specific type for my Windows example is
> spelled `DWORD`. I'm really worried that this special case will become a
> precedent and we'll wind up with -Wformat bei
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124991, @hans wrote:
> In https://reviews.llvm.org/D47290#1124964, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47290#1124956, @hans wrote:
> >
> > > In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
>
hans added a comment.
In https://reviews.llvm.org/D47290#1124964, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1124956, @hans wrote:
>
> > In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
> >
> > > In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> > >
> > >
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124956, @hans wrote:
> In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
>
> > In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> >
> > > If we really want to special-case NSInteger, and given that you're
hans added a comment.
In https://reviews.llvm.org/D47290#1124933, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1124866, @hans wrote:
>
> > If we really want to special-case NSInteger, and given that you're
> > targeting a specific wide-spread pattern maybe that's the right thing to
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1124866, @hans wrote:
> If we really want to special-case NSInteger, and given that you're targeting
> a specific wide-spread pattern maybe that's the right thing to do, I think we
> should make -Wformat accept (move the warning
hans added a comment.
What's special about size_t though? If I understand your patch correctly, it
would suppress warning about printing NSInteger with %zd, but still warn about
%ld even though ssize_t=long on the target? As a user I'd find this confusing.
If we really want to special-case NSIn
aaron.ballman added subscribers: hans, joerg.
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1115352, @jfb wrote:
> Hopefully this makes sense? I'm not sure I summarize my context very well.
> I'm happy to talk about it in-person next week too.
I appreciate the in-person con
jfb added a comment.
In https://reviews.llvm.org/D47290#1113422, @aaron.ballman wrote:
> In https://reviews.llvm.org/D47290#1113412, @jfb wrote:
>
> > In https://reviews.llvm.org/D47290#1113365, @aaron.ballman wrote:
> >
> > > This is relaxing `-Wformat` and making users instead write
> > > `-Wf
aaron.ballman added a comment.
In https://reviews.llvm.org/D47290#1113412, @jfb wrote:
> In https://reviews.llvm.org/D47290#1113365, @aaron.ballman wrote:
>
> > This is relaxing `-Wformat` and making users instead write
> > `-Wformat-pedantic` to get the strong guarantees, which is the opposite
jfb added a comment.
Addressed comments.
Repository:
rC Clang
https://reviews.llvm.org/D47290
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jfb updated this revision to Diff 148737.
jfb marked 2 inline comments as done.
jfb added a comment.
- Fix variable capitalization.
Repository:
rC Clang
https://reviews.llvm.org/D47290
Files:
include/clang/Analysis/Analyses/FormatString.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/
jfb marked an inline comment as done.
jfb added a comment.
In https://reviews.llvm.org/D47290#1113365, @aaron.ballman wrote:
> This is relaxing `-Wformat` and making users instead write
> `-Wformat-pedantic` to get the strong guarantees, which is the opposite of
> what I thought the consensus w
aaron.ballman added a comment.
This is relaxing `-Wformat` and making users instead write `-Wformat-pedantic`
to get the strong guarantees, which is the opposite of what I thought the
consensus was. Have I misunderstood something?
Comment at: include/clang/Analysis/Analyses/F
jfb marked an inline comment as done.
jfb added inline comments.
Comment at: test/SemaObjC/format-size-spec-nsinteger.m:18
+ NSUInteger j = 0;
+ NSLog(@"max NSInteger = %zi", i); // CHECK: values of type 'NSInteger'
should not be used as format arguments; add an explicit cast
jfb updated this revision to Diff 148467.
jfb marked an inline comment as done.
jfb added a comment.
- Merge format-size-spec-nsinteger
Repository:
rC Clang
https://reviews.llvm.org/D47290
Files:
include/clang/Analysis/Analyses/FormatString.h
include/clang/Basic/DiagnosticSemaKinds.td
ahatanak added inline comments.
Comment at: test/SemaObjC/format-size-spec-nsinteger.m:18
+ NSUInteger j = 0;
+ NSLog(@"max NSInteger = %zi", i); // CHECK: values of type 'NSInteger'
should not be used as format arguments; add an explicit cast to 'long' instead
+ NSLog(@"max
jfb marked an inline comment as done.
jfb added inline comments.
Comment at: test/FixIt/fixit-format-ios-nopedantic.m:21
+ printf("test 4: %zd %zd", getNSInteger(), getNSInteger());
+}
alexshap wrote:
> maybe i'm missing smth, but i don't see any verification in
alexshap added inline comments.
Comment at: test/FixIt/fixit-format-ios-nopedantic.m:21
+ printf("test 4: %zd %zd", getNSInteger(), getNSInteger());
+}
maybe i'm missing smth, but i don't see any verification in this test.
Repository:
rC Clang
https://revie
jfb created this revision.
jfb added reviewers: ahatanak, vsapsai, alexshap, aaron.ballman, javed.absar,
jfb, rjmccall.
Herald added subscribers: cfe-commits, aheejin, kristof.beyls.
Pick https://reviews.llvm.org/D42933 back up, and make NSInteger/NSUInteger
with %zu/%zi specifiers on Darwin war
24 matches
Mail list logo
