[PATCH] D47291: Proposal to make rtti errors more generic.

This revision was automatically updated to reflect the committed changes. Closed by commit rC334153: Change the wording of RTTI errors to make them more generic. (authored by ssrivastava, committed by ). Repository: rC Clang https://reviews.llvm.org/D47291 Files:

[PATCH] D47291: Proposal to make rtti errors more generic.

probinson accepted this revision. probinson added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D47291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; wristow wrote: >

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava updated this revision to Diff 150038. Sunil_Srivastava added a comment. Changed as per Paul's suggestion. https://reviews.llvm.org/D47291 Files: include/clang/Basic/DiagnosticSemaKinds.td test/SemaCXX/no-rtti.cpp Index: test/SemaCXX/no-rtti.cpp

[PATCH] D47291: Proposal to make rtti errors more generic.

wristow added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; probinson wrote: >

[PATCH] D47291: Proposal to make rtti errors more generic.

probinson added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; wristow wrote: >

[PATCH] D47291: Proposal to make rtti errors more generic.

wristow added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; Sunil_Srivastava wrote: >

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; probinson wrote:

[PATCH] D47291: Proposal to make rtti errors more generic.

probinson added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; filcab wrote: > I'd

[PATCH] D47291: Proposal to make rtti errors more generic.

filcab added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; I'd prefer to have the way

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava created this revision. Herald added a subscriber: cfe-commits. This patch changes the wording of two errors to make them more generic. An attempt to use dynamic_cast while rtti is disabled, curently emits the error: cannot use dynamic_cast with -fno-rtti and a similar one