[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

2018-09-22 Thread Louis Dionne via Phabricator via cfe-commits
ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM and has been committed -- you can close this. https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

2018-08-07 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal added a reviewer: ldionne. BillyONeal added a comment. Adding ldionne as suggested by Eric. https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

2018-08-07 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal added a comment. Committed r339213 (If there are changes requested I'll do them in a follow up commit) https://reviews.llvm.org/D47395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47395: [libcxx] [test] Remove nonportable locale assumption in basic.ios.members/narrow.pass.cpp

2018-05-25 Thread Billy Robert O'Neal III via Phabricator via cfe-commits
BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. I'm not sure if libcxx is asserting UTF-8 here; but on Windows the full char value is always passed through in its entirety, since the default codepage is something like Windows-1252. The replacement character is