This revision was automatically updated to reflect the committed changes.
Closed by commit rL333723: Filesystem tests: un-confuse write time (authored by
jfb, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D47557
Files:
libcxx/trunk/te
jfb updated this revision to Diff 149398.
jfb added a comment.
- Add back directory test
Repository:
rCXX libc++
https://reviews.llvm.org/D47557
Files:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp
Index:
test/std/experimental/filesystem/fs
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:257
+TEST_CHECK(LastWriteT
jfb updated this revision to Diff 149377.
jfb added a comment.
- Remove access time checks, simplify existing check, after talking to EricWF
on IRC.
Repository:
rCXX libc++
https://reviews.llvm.org/D47557
Files:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_writ
EricWF added a comment.
So the reason there are `atime` tests at all is due to the implementation
details of `__last_write_time` here. Essentially we have to do extra work
trying to maintain the access time.
I'm OK with this patches rename. `first` and `second` were certainly not clear.
That b
vsapsai added inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:257-258
TEST_CHECK(dtime2 > dtime);
-TEST_CHECK(LastAccessTime(file) == file_access_time ||
- LastAccessTime(file) == Clo
vsapsai added inline comments.
Comment at:
test/std/experimental/filesystem/fs.op.funcs/fs.op.last_write_time/last_write_time.pass.cpp:257-258
TEST_CHECK(dtime2 > dtime);
-TEST_CHECK(LastAccessTime(file) == file_access_time ||
- LastAccessTime(file) == Clo
jfb created this revision.
jfb added reviewers: EricWF, mclow.lists, aemerson.
Herald added subscribers: cfe-commits, christof.
The filesystem test was confused about access versus write / modification time.
The spec says:
file_time_type last_write_time(const path& p, error_code& ec) noexcept;
