This revision was automatically updated to reflect the committed changes.
sammccall marked 3 inline comments as done.
Closed by commit rL334712: [clangd] FuzzyMatch: forbid tail-tail matches after
a miss: [pat] !~ panther (authored by sammccall, committed by ).
Herald added a subscriber:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM with a few nits. And comment requests for things that were unclear when
reading the code.
Comment at: clangd/FuzzyMatch.cpp:269
+ :
sammccall added a comment.
@ilya-biryukov ping. I'm excited about this change :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sammccall updated this revision to Diff 151104.
sammccall added a comment.
Fix completion tests. (Simplify a bit - no need to re-test all the nuances of
fuzzy matching there).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
Files:
clangd/FuzzyMatch.cpp
malaperle added a comment.
In https://reviews.llvm.org/D47950#1128487, @sammccall wrote:
> In https://reviews.llvm.org/D47950#1128370, @malaperle wrote:
>
> > Very nice! I tried "std" and got much less (unimportant) results. I see
> > something a bit weird with "getStandardResourceDir" but it
sammccall added a comment.
In https://reviews.llvm.org/D47950#1128370, @malaperle wrote:
> Very nice! I tried "std" and got much less (unimportant) results. I see
> something a bit weird with "getStandardResourceDir" but it might be VSCode.
> Here, I guess it's the "d" in Dir that matches but
malaperle added a comment.
Very nice! I tried "std" and got much less (unimportant) results. I see
something a bit weird with "getStandardResourceDir" but it might be VSCode.
Here, I guess it's the "d" in Dir that matches but what's odd is that VS Code
will highlight the first "d", i.e. in
sammccall updated this revision to Diff 150531.
sammccall added a comment.
Simplify logic/make more consistent. Couple of extra test cases.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D47950
Files:
clangd/FuzzyMatch.cpp
clangd/FuzzyMatch.h
sammccall created this revision.
sammccall added a reviewer: ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous, MaskRay, ioeric.
This is a small code change but vastly reduces noise in code completion results.
The intent of allowing this was to let [sc] ~ "strncpy" and [strcpy] ~
