tra added a comment.
Drive-by review:
The patch could use a better description.
Something that describes *what* the patch does (E.g. enforce that attributes
X/Y/Z are only applied to __global__ functions.)
*why* the change is needed is relevant, too, but it's not very useful without
the *what*
yaxunl created this revision.
yaxunl added a reviewer: kzhuravl.
Herald added subscribers: t-tye, tpr, dstuttard, nhaehnle, wdng.
There are HIP applications e.g. Tensorflow 1.3 using amdgpu kernel attributes.
https://reviews.llvm.org/D47958
Files:
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCUDA/
