spatel added a comment.
In https://reviews.llvm.org/D48134#1131626, @rsmith wrote:
> Can we mark these as `argmemonly`?
I wasn't aware of that one, but it sounds accurate for nan() and friends:
argmemonly
This attribute indicates that the only memory accesses inside function are
loads
lebedev.ri added a comment.
In https://reviews.llvm.org/D48134#1131626, @rsmith wrote:
> Can we mark these as `argmemonly`?
Header comment in `include/clang/Basic/Builtins.def` does not list that as a
possibility.
Repository:
rL LLVM
https://reviews.llvm.org/D48134
rsmith added a comment.
Can we mark these as `argmemonly`?
Repository:
rL LLVM
https://reviews.llvm.org/D48134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL334628: [CodeGen] make nan builtins pure rather than const
(PR37778) (authored by spatel, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Makes sense.
https://reviews.llvm.org/D48134
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
spatel created this revision.
spatel added reviewers: gfalcon, lebedev.ri.
Herald added a subscriber: mcrosier.
https://bugs.llvm.org/show_bug.cgi?id=37778
...shows a miscompile resulting from marking nan builtins as 'const'.
The nan libcalls/builtins take a pointer argument: