[PATCH] D48292: use modern type trait implementations when available

thakis added a comment. Done in r359907, thanks! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48292/new/ https://reviews.llvm.org/D48292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D48292: use modern type trait implementations when available

ldionne added a comment. In D48292#1490060 , @thakis wrote: > This test is broken with Xcode 9: > > [...] > > > Does this just need an `// XFAIL: apple-clang-9` or is this unexpected? This seems to have been fixed in LLVM Clang trunk since the 8

[PATCH] D48292: use modern type trait implementations when available

thakis added a comment. This test is broken with Xcode 9: -- Testing: 53613 tests, 8 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90 FAIL: libc++ :: std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp (50845 of 53613)

[PATCH] D48292: use modern type trait implementations when available

rsmith added a comment. In D48292#1478617 , @ldionne wrote: > I think this broke the C++03 bots: > http://green.lab.llvm.org/green/view/Libcxx/job/libc++%20and%20libc++abi%20trunk/CI_ARCH=64,CI_EXCEPTIONS=ON,CI_STD=c++03/103/consoleFull Thanks, should

[PATCH] D48292: use modern type trait implementations when available

ldionne added a comment. I think this broke the C++03 bots: http://green.lab.llvm.org/green/view/Libcxx/job/libc++%20and%20libc++abi%20trunk/CI_ARCH=64,CI_EXCEPTIONS=ON,CI_STD=c++03/103/consoleFull Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48292/new/

[PATCH] D48292: use modern type trait implementations when available

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) || (_GNUC_VER >= 403) + EricWF wrote: > rsmith wrote: > > EricWF wrote: > > > We don't support anything

[PATCH] D48292: use modern type trait implementations when available

EricWF added a comment. This patch is OK to land as-is. Doing the cleanup separately makes sense. Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) || (_GNUC_VER >= 403) + rsmith wrote: > EricWF wrote: > > We don't support

[PATCH] D48292: use modern type trait implementations when available

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX359159: Use modern type trait implementations when available. (authored by rsmith, committed by ). Changed prior to commit: https://reviews.llvm.org/D48292?vs=151761=196559#toc Repository: rCXX

[PATCH] D48292: use modern type trait implementations when available

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) || (_GNUC_VER >= 403) + EricWF wrote: > We don't support anything before GCC 4.9, so you can replace the

[PATCH] D48292: use modern type trait implementations when available

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Herald added subscribers: libcxx-commits, miyuki, jfb, ldionne. LGTM minus nits. Comment at: include/type_traits:3683 + +#elif __has_feature(has_trivial_destructor) ||

[PATCH] D48292: use modern type trait implementations when available

rsmith created this revision. rsmith added reviewers: EricWF, mclow.lists. Herald added a subscriber: cfe-commits. Teach libcxx to stop using various deprecated __has_* type traits, in favor of the ("modern", C++11 era) __is_* type traits. This is mostly just a simplification, but fixes at