[PATCH] D48352: [clang-format] Improve ObjC method expressions formatting

2018-06-28 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak abandoned this revision. jolesiak added a comment. Split: https://reviews.llvm.org/D48716 https://reviews.llvm.org/D48718 https://reviews.llvm.org/D48719 https://reviews.llvm.org/D48720 Repository: rC Clang https://reviews.llvm.org/D48352 __

[PATCH] D48352: [clang-format] Improve ObjC method expressions formatting

2018-06-27 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak added a comment. In https://reviews.llvm.org/D48352#1145220, @benhamilton wrote: > It's really hard to understand reviews which change 4 different things. > > I hate to ask, but can you split this up into the 4 fixes? Sure, I'll split it tomorrow. Repository: rC Clang https://revi

[PATCH] D48352: [clang-format] Improve ObjC method expressions formatting

2018-06-27 Thread Ben Hamilton via Phabricator via cfe-commits
benhamilton requested changes to this revision. benhamilton added a comment. This revision now requires changes to proceed. It's really hard to understand reviews which change 4 different things. I hate to ask, but can you split this up into the 4 fixes? Repository: rC Clang https://reviews.

[PATCH] D48352: [clang-format] Improve ObjC method expressions formatting

2018-06-20 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak updated this revision to Diff 152043. jolesiak added a comment. - Add test Repository: rC Clang https://reviews.llvm.org/D48352 Files: lib/Format/ContinuationIndenter.cpp lib/Format/FormatToken.h lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index: unitt

[PATCH] D48352: [clang-format] Improve ObjC method expressions formatting

2018-06-20 Thread Jacek Olesiak via Phabricator via cfe-commits
jolesiak created this revision. Herald added a subscriber: cfe-commits. 1. Fix counting parameters/arguments for ObjC. 2. Fix split priorities for ObjC methods. 3. Fix breaking after square bracket starting ObjC method expression. 4. Fix putting ObjC method arguments into one line when they fit.