[PATCH] D48412: [RISCV] Support for __attribute__((interrupt))

2018-06-21 Thread Ana Pazos via Phabricator via cfe-commits
apazos updated this revision to Diff 152416. apazos added a comment. Herald added subscribers: brucehoult, MartinMosbeck. Hi Simon, I have added a warning for repeated interrupt attributes. https://reviews.llvm.org/D48412 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

[PATCH] D48412: [RISCV] Support for __attribute__((interrupt))

2018-06-21 Thread Simon Cook via Phabricator via cfe-commits
simoncook added a comment. I think this should also cover mismatched arguments if the attribute appears several times, and reject/warn about the attribute combination in these cases. For example, `__attribute__((interrupt("machine"))) __attribute__((interrupt("user"))) void foo() {}` is

[PATCH] D48412: [RISCV] Support for __attribute__((interrupt))

2018-06-20 Thread Ana Pazos via Phabricator via cfe-commits
apazos created this revision. apazos added a reviewer: asb. Herald added subscribers: rogfer01, mgrang, edward-jones, zzheng, shiva0217, kito-cheng, niosHD, sabuasal, simoncook, johnrusso, rbar. Clang supports the GNU style ``__attribute__((interrupt))`` attribute on RISCV targets. Permissible