This revision was automatically updated to reflect the committed changes.
Closed by commit rL335634: [HIP] Remove hip/hc.amdgcn.bc from HIP Toolchains
(authored by aaronenyeshi, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D48455?vs=
gregrodgers added a comment.
Why not provide a specific list of --hip-device-lib= for VDI builds? I am not
sure about defining functions inside headers instead of using a hip bc lib.
Repository:
rC Clang
https://reviews.llvm.org/D48455
___
cfe
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D48455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
ashi1 created this revision.
ashi1 added a reviewer: yaxunl.
ashi1 added projects: clang, AMDGPU.
Herald added a subscriber: cfe-commits.
Removing hip.amdgcn.bc and hc.amdgcn.bc from HIP ToolChains. These need to be
removed in VDI build.
Repository:
rC Clang
https://reviews.llvm.org/D48455
