[PATCH] D48460: [analyzer] Fix invalidation on C++ const methods.

2018-06-25 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC33: [analyzer] Fix invalidation on C++ const methods with arrow syntax. (authored by dergachev, committed by ). Changed prior to commit: https://reviews.llvm.org/D48460?vs=152391&id=152805#toc Repo

[PATCH] D48460: [analyzer] Fix invalidation on C++ const methods.

2018-06-24 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang https://reviews.llvm.org/D48460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org

[PATCH] D48460: [analyzer] Fix invalidation on C++ const methods.

2018-06-23 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Well, i guess that's just one of those mildly infuriating aspects of the AST and/or the standard :) > If references are resolved, why are pointers not? It's kinda understandable. References are simple aliases to glvalues. When you use a reference, you simply get *the* orig

[PATCH] D48460: [analyzer] Fix invalidation on C++ const methods.

2018-06-21 Thread Balogh , Ádám via Phabricator via cfe-commits
baloghadamsoftware added a comment. I find it a strange behavior that this-expression is sometimes a pointer, sometimes a record declaration. If references are resolved, why are pointers not? This is an important fix, but I wonder how many other places are in the code where we do not handle th

[PATCH] D48460: [analyzer] Fix invalidation on C++ const methods.

2018-06-21 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet, rnkovacs. Herald added subscribers: cfe-commits, mikhail.ramalho, baloghadamsoftware. `const` methods shouldn't invalidate the object unless mutable fields kick in. They sometimes were inva