[PATCH] D48492: [clang-format] Add a default format style that can be used by users of `getStyle`

2018-06-25 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL335492: [clang-format] Add a default format style that can be used by users of… (authored by ioeric, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.or

[PATCH] D48492: [clang-format] Add a default format style that can be used by users of `getStyle`

2018-06-25 Thread Eric Liu via Phabricator via cfe-commits
ioeric added inline comments. Comment at: tools/clang-format/ClangFormat.cpp:67 static cl::opt FallbackStyle("fallback-style", cl::desc("The name of the predefined style used as a\n" sammccall wrote: > My only question is if we want to do the sam

[PATCH] D48492: [clang-format] Add a default format style that can be used by users of `getStyle`

2018-06-25 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 152636. ioeric marked an inline comment as done. ioeric added a comment. - Add DefaultFallbackStyle Repository: rC Clang https://reviews.llvm.org/D48492 Files: include/clang/Format/Format.h lib/Format/Format.cpp tools/clang-format/ClangFormat.cpp

[PATCH] D48492: [clang-format] Add a default format style that can be used by users of `getStyle`

2018-06-22 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. I think this should work great for us, and hopefully helps other downstream users too. (@djasper: the plan is to introduce a new style name for our tweaked version of `"file"`, and make

[PATCH] D48492: [clang-format] Add a default format style that can be used by users of `getStyle`

2018-06-22 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added reviewers: sammccall, djasper. Herald added a subscriber: cfe-commits. Tools that reformat code often call `getStyle` to decide the format style to use on a certain source file. In practice, "file" style is widely used. As a result, many tools hardcode "f