rtrieu added a comment.
Hey Vassil,
I have been giving this a little more thought and I have a solution I'd like
you to try out. If the type pointers aren't unique enough, then the indexing
scheme will not work for hashing. Can you try this idea in your build
environment and see if works
rtrieu added a comment.
Running this, I see that it causes a regression in one of the other ODR Hash
tests. Specifically, the diagnostics on line 1150 & 1151 of
test/Modules/odr_hash.cpp are not seen. Was that an expected side-effect of
this patch?
Repository:
rC Clang
v.g.vassilev created this revision.
v.g.vassilev added reviewers: rsmith, rtrieu, bruno.
Herald added a subscriber: cfe-commits.
r332281 (https://reviews.llvm.org/D45463) teaches the ASTContext to generate
different elaborated types if there is an owning tag. This exposed a bug with
our odr
