This revision was automatically updated to reflect the committed changes.
Closed by commit rL335899: [CMake] Rename cxx_headers back to cxx-headers.
(authored by ab, committed by ).
Herald added subscribers: llvm-commits, christof.
Changed prior to commit:
https://reviews.llvm.org/D48701?vs=153
phosek added a comment.
It's not obvious to me how anything could depend on `cxx-header`s target (not
the component) since that target did not exist until r334468 which has landed
only recently (just before r334477). The motivation behind this change was just
consistency since all other targets
phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCXX libc++
https://reviews.llvm.org/D48701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
ab created this revision.
ab added a reviewer: phosek.
Herald added subscribers: ldionne, mgorny.
r334477 renamed the cxx-headers target to cxx_headers, but various pieces
sort-of expect the target names to match the component (e.g.,
LLVM_DISTRIBUTION_COMPONENTS in the various bootstrap caches,
