[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

This revision was automatically updated to reflect the committed changes. Closed by commit rL336168: [Driver][Darwin] Use Host Triple to infer target os version (authored by steven_wu, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D48849

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D48849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

steven_wu updated this revision to Diff 153836. steven_wu added a comment. It is easier and cleaner if I just fold everything into getOSVersion. Repository: rC Clang https://reviews.llvm.org/D48849 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/clang-g-opts.c test/Driver/target-tr

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

arphaman added a comment. Nit: Could you please try to extract the shared code into a function, e.g. Optional overrideMacOSTripleDefaultVersion(const llvm::Triple &Triple, ... OSTy, ... TheDriver) { if (Triple.getOSMajorVersion()) return None; llvm::Triple SystemTriple(llvm

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

steven_wu updated this revision to Diff 153822. steven_wu added a comment. handle *-apple-macosx target option Repository: rC Clang https://reviews.llvm.org/D48849 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/clang-g-opts.c test/Driver/target-triple-deployment.c Index: test/Dr

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

steven_wu added a comment. In https://reviews.llvm.org/D48849#1150246, @arphaman wrote: > Hmm, the driver should not call `inferDeploymentTargetFromArch` when > `-target` is passed. Or am I missing something? Good call. This only handles the *-apple-darwin case. Maybe the same should happen t

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

arphaman added a comment. Hmm, the driver should not call `inferDeploymentTargetFromArch` when `-target` is passed. Or am I missing something? Repository: rC Clang https://reviews.llvm.org/D48849 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

steven_wu updated this revision to Diff 153816. steven_wu added a comment. Rebase the commit correctly Repository: rC Clang https://reviews.llvm.org/D48849 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/clang-g-opts.c Index: test/Driver/clang-g-opts.c =

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

steven_wu updated this revision to Diff 153814. steven_wu added a comment. Update patch. Use a better API. Repository: rC Clang https://reviews.llvm.org/D48849 Files: lib/Driver/ToolChains/Darwin.cpp test/Driver/clang-g-opts.c Index: test/Driver/clang-g-opts.c =

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

steven_wu added a comment. Unfortunately, I wasn't able to write a test for this because the host triple in the configuration can either be x86_64-apple-darwin* or x86_64-apple-macosx*, but the one used passed by driver is always macosx one. I can't reliably compare those two. Repository: r

[PATCH] D48849: [Driver][Darwin] Use Host Triple to infer target os version

steven_wu created this revision. steven_wu added reviewers: arphaman, dexonsmith. When clang required to infer target os version from --target option and the os version is not specified in targets, check the host triple. If the host and target are both macOS, use host triple to infer target os ver