[PATCH] D48933: [clangd] Treat class constructor as in the same scope as the class in ranking.

2018-07-05 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE336318: [clangd] Treat class constructor as in the same scope as the class in ranking. (authored by ioeric, committed by ). Changed prior to commit:

[PATCH] D48933: [clangd] Treat class constructor as in the same scope as the class in ranking.

2018-07-05 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 154182. ioeric added a comment. - Refactored findAnyDecl. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48933 Files: clangd/Quality.cpp unittests/clangd/QualityTests.cpp unittests/clangd/TestTU.cpp unittests/clangd/TestTU.h Index:

[PATCH] D48933: [clangd] Treat class constructor as in the same scope as the class in ranking.

2018-07-05 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: unittests/clangd/QualityTests.cpp:218 + + // `findDecl` would return the implicit injected class for "Foo::Foo"; simply + // look for a constructor

[PATCH] D48933: [clangd] Treat class constructor as in the same scope as the class in ranking.

2018-07-04 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, jkorous, MaskRay, ilya-biryukov. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D48933 Files: clangd/Quality.cpp unittests/clangd/QualityTests.cpp Index: