This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE336538: [clangd] Wait for first preamble before code
completion (authored by ibiryukov, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D48940?vs=154562=154563#toc
Repository:
rL
This revision was automatically updated to reflect the committed changes.
Closed by commit rL336538: [clangd] Wait for first preamble before code
completion (authored by ibiryukov, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D48940
ilya-biryukov updated this revision to Diff 154562.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Add a test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D48940
Files:
clangd/TUScheduler.cpp
clangd/TUScheduler.h
ilya-biryukov added a comment.
In https://reviews.llvm.org/D48940#1152750, @sammccall wrote:
> Possible test: add a file with complicated preamble (billion laughs?) and
> immediately schedule 5 preamble actions. They should all get a non-null
> preamble and the pointers should all be the same.
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Nice fix!
Possible test: add a file with complicated preamble (billion laughs?) and
immediately schedule 5 preamble actions. They should all get a non-null
preamble and the pointers
ilya-biryukov created this revision.
ilya-biryukov added a reviewer: sammccall.
Herald added subscribers: jkorous, MaskRay, ioeric, javed.absar.
To avoid doing extra work of processing headers in the preamble
mutilple times in parallel.
Repository:
rCTE Clang Tools Extra
