This revision was automatically updated to reflect the committed changes.
Closed by commit rC339240: [analyzer][UninitializedObjectChecker]
Pointer/reference objects are… (authored by Szelethus, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D49199
Files:
Szelethus updated this revision to Diff 159699.
Szelethus added a comment.
Rebased to latest trunk.
https://reviews.llvm.org/D49199
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
Szelethus added a comment.
Thanks! I plan on revisiting how heap allocated regions are handled in the
future.
https://reviews.llvm.org/D49199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ accepted this revision.
NoQ added a comment.
This looks roughly correct, but at the same time none of the tests actually
exercise the dynamic type propagation. In these tests all the necessary
information is obtained from the structure of the MemRegion (directly or via
the initial
Szelethus added a comment.
@NoQ, we had quite a few conversations about this fix. How do you feel about
this implementation?
https://reviews.llvm.org/D49199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
george.karpenkov requested changes to this revision.
george.karpenkov added a comment.
This revision now requires changes to proceed.
Cf. my comments to https://reviews.llvm.org/D49437: is it possible to separate
pointer-chasing from the rest of the checker?
https://reviews.llvm.org/D49199
Szelethus updated this revision to Diff 155913.
Szelethus added a comment.
Rebased to the latest trunk.
https://reviews.llvm.org/D49199
Files:
lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp
test/Analysis/cxx-uninitialized-object-inheritance.cpp
Szelethus added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/UninitializedObjectChecker.cpp:591-609
+// TODO: This function constructs an incorrect string if a void pointer is a
+// part of the chain:
+//
+// struct B { int x; }
+//
+// struct A {
+// void
Szelethus created this revision.
Szelethus added reviewers: NoQ, george.karpenkov, xazax.hun, rnkovacs.
Herald added subscribers: cfe-commits, mikhail.ramalho, a.sidorin, szepet,
whisperity.
This diff fixes a long debated issues with pointers/references not being
dereferenced according to their
