[PATCH] D49338: Implement - P0122R7

mclow.lists closed this revision. mclow.lists added a comment. Landed as r337804. https://reviews.llvm.org/D49338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49338: Implement - P0122R7

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM, with a suggestion for adding one test. Comment at: include/span:189 +struct __is_span_compatible_container<_Tp, _ElementType, +void_t< +// is not a

[PATCH] D49338: Implement - P0122R7

ldionne added inline comments. Comment at: include/span:217 +using pointer= _Tp *; +using const_pointer = const _Tp *; // not in standard +using reference = _Tp &; mclow.lists wrote: > ldionne wrote: > > Why are

[PATCH] D49338: Implement - P0122R7

mclow.lists marked an inline comment as done. mclow.lists added a comment. > I missed the container constructors being `noexcept` Never mind; they're not `noexcept` (and they should not be) https://reviews.llvm.org/D49338 ___ cfe-commits mailing

[PATCH] D49338: Implement - P0122R7

mclow.lists marked 13 inline comments as done. mclow.lists added a comment. I missed the container constructors being `noexcept`, and the asserts on `operator[]` and `operator()` are half done (stupid signed indicies). I'll wait for other feedback before doing those bits.

[PATCH] D49338: Implement - P0122R7

mclow.lists marked 5 inline comments as done. mclow.lists added a comment. I think I've answered all of Louis' questions that don't require code changes. New patch will be coming soon. Comment at: include/span:217 +using pointer= _Tp *; +using

[PATCH] D49338: Implement - P0122R7

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. My comments are based off of http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0122r7.pdf. Comment at: include/span:189 +struct

[PATCH] D49338: Implement - P0122R7

STL_MSFT added inline comments. Comment at: test/std/containers/views/span.comparison/op.eq.pass.cpp:23 +#include +#include + The comparison tests appear to be unnecessarily including ``. Comment at:

[PATCH] D49338: Implement - P0122R7

mclow.lists added a comment. Need to add an entry to `include/CMakeLists.txt` as well. https://reviews.llvm.org/D49338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49338: Implement - P0122R7

mclow.lists added inline comments. Comment at: include/span:236 +_LIBCPP_INLINE_VISIBILITY constexpr span(pointer __ptr, index_type __count) : __data{__ptr} +{ assert(_Extent == __count); } +_LIBCPP_INLINE_VISIBILITY constexpr span(pointer __f, pointer __l) :