[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

2018-07-20 Thread Petr Hosek via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL337630: [CMake] Install C++ ABI headers into the right location (authored by phosek, committed by ). Herald added a

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

2018-07-20 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a subscriber: beanz. phosek added a comment. We currently support two different layouts: 1. The standard layout (for a lack of a better name) which is used when libc++ is built standalone as well as being built as part of LLVM without any other options which is

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

2018-07-20 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a comment. This change LGTM. However, I do have a question about the overall change (including r335809 and r337118). Why is it that we're not simply relying on the `CMAKE_INSTALL_PREFIX` being set to the path where we should install instead of using all these custom variables

[PATCH] D49584: [CMake] Install C++ ABI headers into the right location

2018-07-19 Thread Petr Hosek via Phabricator via cfe-commits
phosek created this revision. phosek added reviewers: ldionne, EricWF. Herald added subscribers: cfe-commits, christof, mgorny. This is a follow-up to r335809 and r337118. While libc++ headers are now installed into the right location in both standard as well as multiarch runtimes layout,