This revision was automatically updated to reflect the committed changes.
Closed by commit rL337717: [DebugInfo] Error out when enabling
-fdebug-types-section on non-ELF target. (authored by JDevlieghere, committed
by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.
If the plan is for this to be relatively temporary then LGTM.
https://reviews.llvm.org/D49594
___
cfe-commits mailing list
JDevlieghere added a comment.
In https://reviews.llvm.org/D49594#1169809, @probinson wrote:
> Is this because type units depend on COMDAT support? I had a vague idea that
> COFF also supports COMDAT.
It's more that I want to reflect the current situation and prevent MC from
crashing while
probinson added a comment.
Is this because type units depend on COMDAT support? I had a vague idea that
COFF also supports COMDAT.
https://reviews.llvm.org/D49594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JDevlieghere updated this revision to Diff 156471.
JDevlieghere added a comment.
Thanks, I meant to use `isOSBinFormatELF` but I think it got lost in an
accidental undo. The test didn't capture that because it's using a linux target
triple.
https://reviews.llvm.org/D49594
Files:
labath added a comment.
I believe debug_types is used on non-linux targets as well. Judging by the
other review all ELF targets should at least have a chance of working, so maybe
key the error off of that?
Repository:
rC Clang
https://reviews.llvm.org/D49594
JDevlieghere added a comment.
Please see PR38190 for more details.
Repository:
rC Clang
https://reviews.llvm.org/D49594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere created this revision.
JDevlieghere added reviewers: labath, dblaikie, probinson.
Currently, support for debug_types is only present for ELF and trying to pass
-fdebug-types-section for other targets results in a crash in the backend.
Until this is fixed, we should emit a
