[PATCH] D49793: [AArch64] - return address signing

hctim added a comment. Herald added a project: LLVM. This change broke the sanitizer buildbots. Please see here for more information:

[PATCH] D49793: [AArch64] - return address signing

This revision was automatically updated to reflect the committed changes. Closed by commit rL340018: [AArch64] - Generate pointer authentication instructions (authored by LukeCheeseman, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D49793: [AArch64] - return address signing

olista01 accepted this revision. olista01 added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D49793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D49793: [AArch64] - return address signing

LukeCheeseman added a comment. ping https://reviews.llvm.org/D49793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D49793: [AArch64] - return address signing

LukeCheeseman updated this revision to Diff 158491. LukeCheeseman added a comment. Move -msign-return-address argument handling into AArch64TargetArgs https://reviews.llvm.org/D49793 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

[PATCH] D49793: [AArch64] - return address signing

LukeCheeseman added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.h:114 +Partial,// Sign the return address of functions that spill LR +All // Sign the return address of all functions + }; kcc wrote: > what's the

[PATCH] D49793: [AArch64] - return address signing

LukeCheeseman updated this revision to Diff 157444. LukeCheeseman added a comment. Change codegen option partial to non-leaf to match msign-return-address scope values https://reviews.llvm.org/D49793 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def

[PATCH] D49793: [AArch64] - return address signing

kcc added inline comments. Comment at: include/clang/Frontend/CodeGenOptions.h:114 +Partial,// Sign the return address of functions that spill LR +All // Sign the return address of all functions + }; what's the purpose of signing LR

[PATCH] D49793: [AArch64] - return address signing

LukeCheeseman updated this revision to Diff 157266. LukeCheeseman edited the summary of this revision. https://reviews.llvm.org/D49793 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def include/clang/Frontend/CodeGenOptions.h lib/CodeGen/TargetInfo.cpp

[PATCH] D49793: [AArch64] - return address signing

javed.absar added a comment. Maybe you can provide some more context to this patch (why you need this, or point to some document), if possible. Comment at: include/clang/Frontend/CodeGenOptions.h:111 + enum SignReturnAddressScope { None, Partial, All }; +