This revision was automatically updated to reflect the committed changes.
Closed by commit rL339226: [ASTImporter] Load external Decls when getting field
index. (authored by balazske, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D49796
balazske updated this revision to Diff 159659.
balazske added a comment.
- Added common getFieldIndex.
- Corrected test ImportUnnamedFieldsInCorrectOrder.
Repository:
rC Clang
https://reviews.llvm.org/D49796
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
balazske updated this revision to Diff 159467.
balazske added a comment.
- Added common getFieldIndex.
Repository:
rC Clang
https://reviews.llvm.org/D49796
Files:
include/clang/AST/ASTImporter.h
lib/AST/ASTImporter.cpp
test/ASTMerge/unnamed_fields/Inputs/il.cpp
a_sidorin added a comment.
Hi Balázs,
The approach is OK but I have some minor comments inline.
Comment at: lib/AST/ASTImporter.cpp:2840
- return Index;
+ assert(false && "Field was not found in its parent context.");
+
`llvm_unreachable`?
balazske created this revision.
Herald added subscribers: cfe-commits, martong.
Herald added a reviewer: a.sidorin.
At equality check of fields without name the index of fields is compared.
At determining the index of a field all fields of the parent context
should be loaded from external source
