[PATCH] D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while

2018-08-03 Thread Martin Böhme via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCTE338932: [clang-tidy] Sequence init statements, declarations, and conditions correctly… (authored by mboehme, committed by ). Changed prior to commit:

[PATCH] D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while

2018-08-03 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 159093. mboehme added a comment. Apply clang-format. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49918 Files: clang-tidy/utils/ExprSequence.cpp test/clang-tidy/bugprone-use-after-move.cpp Index:

[PATCH] D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while

2018-08-03 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. Still LG Comment at: test/clang-tidy/bugprone-use-after-move.cpp:1141 +A a1; +if (A a2= std::move(a1)) { + std::move(a2); nit: clang-format this, please. Repository: rCTE Clang Tools Extra

[PATCH] D49918: [clang-tidy] Sequence init statements, declarations, and conditions correctly in if, switch, and while

2018-08-03 Thread Martin Böhme via Phabricator via cfe-commits
mboehme marked an inline comment as done. mboehme added a comment. Any further comments? This is marked ready to land, but I've made some non-trivial changes since then, so I didn't just want to land this. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D49918