ldionne abandoned this revision.
ldionne added a comment.
Nevermind, it looks like this patch is not necessary anymore since
https://reviews.llvm.org/D45015 landed.
Repository:
rCXX libc++
https://reviews.llvm.org/D50205
___
cfe-commits mailing
ldionne added a comment.
In https://reviews.llvm.org/D50205#1188454, @EricWF wrote:
> How does this work when a user provides their own definitions? Does the
> attribute from the declaration still produce a warning? If so, then I think
> an in-compiler approach is better.
Yes. I do agree
EricWF added a comment.
How does this work when a user provides their own definitions? Does the
attribute from the declaration still produce a warning? If so, then I think an
in-compiler approach is better.
Repository:
rCXX libc++
https://reviews.llvm.org/D50205
ldionne updated this revision to Diff 159110.
ldionne added a comment.
Only include availability markup in this patch, do not change whether and when
aligned allocation functions are used by the library. This will be handled in a
separate patch.
Repository:
rCXX libc++
ldionne added a comment.
In https://reviews.llvm.org/D50205#1186419, @ahatanak wrote:
> I just wanted to make sure that this doesn't have the same problem as
> https://reviews.llvm.org/D34556. Is that correct?
>
> The patch was reverted in r306859. https://reviews.llvm.org/D34574#791158
>
ahatanak added a comment.
I just wanted to make sure that this doesn't have the same problem as
https://reviews.llvm.org/D34556. Is that correct?
The patch was reverted in r306859. https://reviews.llvm.org/D34574#791158
explains why the approach taken in the patch was wrong.
Repository:
ldionne created this revision.
ldionne added reviewers: EricWF, vsapsai.
Herald added subscribers: cfe-commits, dexonsmith, christof.
The aligned allocation and deallocation functions were added in the dylib
in Mac OSX 10.13. This commit does two things: first, it adds availability
markup to
