[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

This revision was automatically updated to reflect the committed changes. Closed by commit rC338916: [OpenMP] Encode offload target triples into comdat key for offload… (authored by sdmitriev, committed by ). Repository: rC Clang https://reviews.llvm.org/D50218 Files:

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D50218 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev updated this revision to Diff 159074. https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/openmp_offload_registration.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp === ---

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3828-3829 +RegFnNameParts[1] = "descriptor_reg"; +for (size_t I = 0; I < Devices.size(); ++I) + RegFnNameParts[I + 2U] = Devices[I].getTriple(); +llvm::sort(RegFnNameParts.begin() + 2,

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev updated this revision to Diff 159058. https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRuntime.cpp test/OpenMP/openmp_offload_registration.cpp Index: lib/CodeGen/CGOpenMPRuntime.cpp === ---

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3825 +// this particular combination of offloading targets. +SmallVector RegFnNameParts; +RegFnNameParts.push_back("omp_offloading"); ABataev wrote: > Preallocate the memory

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3825 +// this particular combination of offloading targets. +SmallVector RegFnNameParts; +RegFnNameParts.push_back("omp_offloading"); Preallocate the memory for all elements

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev updated this revision to Diff 159028. sdmitriev added a comment. Replaced std::sort with llvm::sort. Added a test for offload target registration code for two offload targets. https://reviews.llvm.org/D50218 Files: lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

mgrang added a comment. Please add some unit tests. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3830 + RegFnNameParts.push_back(Device.getTriple()); +std::sort(RegFnNameParts.begin() + 2, RegFnNameParts.end()); +std::string Descriptor = getName(RegFnNameParts);

[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

sdmitriev created this revision. sdmitriev added reviewers: ABataev, hfinkel. Herald added subscribers: cfe-commits, mgrang, guansong. Encoding offload target triples onto comdat group key for offload initialization code guarantees that it will be executed once per each unique combination of