[PATCH] D50255: Add test for changing build configuration

2018-08-03 Thread Simon Marchi via Phabricator via cfe-commits
simark added a comment. In https://reviews.llvm.org/D50255#1187871, @arphaman wrote: > Thanks! This LGTM. Well, thanks for the hints! Repository: rL LLVM https://reviews.llvm.org/D50255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50255: Add test for changing build configuration

2018-08-03 Thread Simon Marchi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL338914: [clangd] Add test for changing build configuration (authored by simark, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D50255 Files:

[PATCH] D50255: Add test for changing build configuration

2018-08-03 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Thanks! This LGTM. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50255 ___ cfe-commits mailing list

[PATCH] D50255: Add test for changing build configuration

2018-08-03 Thread Simon Marchi via Phabricator via cfe-commits
simark updated this revision to Diff 159050. simark added a comment. The tests now work on Windows, I added some path adjustment steps. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50255 Files: test/clangd/compile-commands-path-in-initialize.test

[PATCH] D50255: Add test for changing build configuration

2018-08-03 Thread Simon Marchi via Phabricator via cfe-commits
simark added a comment. This was not tested on windows yet. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D50255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50255: Add test for changing build configuration

2018-08-03 Thread Simon Marchi via Phabricator via cfe-commits
simark created this revision. Herald added subscribers: cfe-commits, arphaman, jkorous, ioeric, ilya-biryukov. This patch adds tests for the two ways of changing build configuration (pointing to a particular compile_commands.json): - Through the workspace/didChangeConfiguration notification. -