[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-09-03 Thread Brian Gesiak via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL341327: Removing -debug-info-macros from option suggestions test (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D50410

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-08-16 Thread Matt Davis via Phabricator via cfe-commits
mattd added a comment. In https://reviews.llvm.org/D50410#1202597, @acoomans wrote: > @mattd thanks for confirming. I tried `clang -cc1as -target x86_64-scei-ps4 > -debug-info-macros` and got suggestions. > > @modocache @mattd Should we try to first land https://reviews.llvm.org/D50515 > to see

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-08-16 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans added a comment. @mattd thanks for confirming. I tried `clang -cc1as -target x86_64-scei-ps4 -debug-info-macros` and got suggestions. @modocache @mattd Should we try to first land https://reviews.llvm.org/D50515 to see if it fails again? Repository: rC Clang https://reviews.llvm.o

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-08-16 Thread Matt Davis via Phabricator via cfe-commits
mattd added a comment. In https://reviews.llvm.org/D50410#1201206, @acoomans wrote: > @mattd @Sunil_Srivastava if you have access to the PS4 SDK, could you tell if > the `-debug-info-macro` command line clang option is available? Thank you Hi @acoomans, The ps4 buildbot should be running with

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-08-15 Thread Brian Gesiak via Phabricator via cfe-commits
modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. I don't have access to the PS4 SDK, but this is the most plausible explanation I've seen for why I was experiencing issues on these platforms. Thanks for this! Do you have commit access

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-08-15 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans added subscribers: mattd, Sunil_Srivastava. acoomans added a comment. @mattd @Sunil_Srivastava if you have access to the PS4 SDK, could you tell if the `-debug-info-macro` command line clang option is available? Thank you Repository: rC Clang https://reviews.llvm.org/D50410 _

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-08-13 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans added a comment. Can anyone confirm the `-debug-info-macro` command line option is unavailable with the PS4 SDK? Repository: rC Clang https://reviews.llvm.org/D50410 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-08-07 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans added a subscriber: probinson. acoomans added a comment. @probinson does this sound a plausible explanation? Do you have access to a PS4 SDK to confirm the `-debug-info-macro` isn't available at all? Repository: rC Clang https://reviews.llvm.org/D50410 ___

[PATCH] D50410: Removing -debug-info-macros from option suggestions test

2018-08-07 Thread Arnaud Coomans via Phabricator via cfe-commits
acoomans created this revision. acoomans added reviewers: cfe-commits, modocache. Herald added subscribers: dexonsmith, JDevlieghere, mehdi_amini. https://reviews.llvm.org/D46776 added support for "did you mean ...?" command line option suggestions. One of the tests was checking against the `-de