[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal closed this revision. BillyONeal added a comment. Committed r344820 https://reviews.llvm.org/D50549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal updated this revision to Diff 160498. BillyONeal edited the summary of this revision. BillyONeal added a comment. Remove changes to detach tests. https://reviews.llvm.org/D50549 Files: test/std/thread/thread.threads/thread.thread.class/thread.thread.constr/F.pass.cpp Index:

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > BillyONeal wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

dvyukov added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); BillyONeal wrote: > dvyukov wrote: > >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:75 assert(G::op_run); assert(G::n_alive == 1); } Actually I just realized that this assert is bogus too;

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > BillyONeal wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

dvyukov added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); BillyONeal wrote: > BillyONeal wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); BillyONeal wrote: > dvyukov wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > BillyONeal wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

dvyukov added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); BillyONeal wrote: > BillyONeal wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); BillyONeal wrote: > dvyukov wrote: >

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); dvyukov wrote: > I don't immediately

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

dvyukov added inline comments. Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:73 assert(!t0.joinable()); while (!done) {} assert(G::op_run); I don't immediately see how the race on

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

jfb added a comment. CC some sanitizer folks. https://reviews.llvm.org/D50549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

EricWF added a comment. I was hoping my comment would summon them magically. I'll figure it out shortly. https://reviews.llvm.org/D50549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal added a comment. In https://reviews.llvm.org/D50549#1194852, @EricWF wrote: > We should add some TSAN folks to this review, since I think these are also > TSAN false negatives; perhaps correctly, perhaps not. Do you know who that is / can you add them?

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

EricWF added a comment. We should add some TSAN folks to this review, since I think these are also TSAN false negatives; perhaps correctly, perhaps not. https://reviews.llvm.org/D50549 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests

BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. Herald added a subscriber: jfb. - Repair thread-unsafe modifications of n_alive in F.pass.cpp In this example, the ctor of G runs in the main thread in the expression G(), and also in the copy ctor of G() in the