arphaman added a comment.
In https://reviews.llvm.org/D50571#1208635, @joaotavora wrote:
> In https://reviews.llvm.org/D50571#1206020, @arphaman wrote:
>
> > In https://reviews.llvm.org/D50571#1205650, @joaotavora wrote:
> >
> > > > LGTM. Let's watch out for possible breakages in any of the
joaotavora added a comment.
In https://reviews.llvm.org/D50571#1206020, @arphaman wrote:
> In https://reviews.llvm.org/D50571#1205650, @joaotavora wrote:
>
> > > LGTM. Let's watch out for possible breakages in any of the clients,
> > > though. I've checked VSCode and it seems to be fine with
arphaman added a comment.
In https://reviews.llvm.org/D50571#1205650, @joaotavora wrote:
> > LGTM. Let's watch out for possible breakages in any of the clients, though.
> > I've checked VSCode and it seems to be fine with the added fields.
>
> This isn't in the spec and broke the LSP client
joaotavora added a comment.
Herald added a subscriber: kadircet.
> LGTM. Let's watch out for possible breakages in any of the clients, though.
> I've checked VSCode and it seems to be fine with the added fields.
This isn't in the spec and broke the LSP client eglot
This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE339738: [clangd] add an extension field to LSP to transfer
the diagnostics category (authored by arphaman, committed by ).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50571
Files:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM. Let's watch out for possible breakages in any of the clients, though.
I've checked VSCode and it seems to be fine with the added fields.
Repository:
rCTE Clang Tools
arphaman updated this revision to Diff 160464.
arphaman marked 2 inline comments as done.
arphaman added a comment.
Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D50571
Files:
clangd/ClangdLSPServer.cpp
clangd/Diagnostics.cpp
clangd/Diagnostics.h
ilya-biryukov added inline comments.
Comment at: clangd/Diagnostics.h:40
DiagnosticsEngine::Level Severity = DiagnosticsEngine::Note;
+ unsigned Category;
// Since File is only descriptive, we store a separate flag to distinguish
Maybe store the string
arphaman created this revision.
arphaman added reviewers: jkorous, ilya-biryukov, sammccall.
Herald added subscribers: dexonsmith, MaskRay, ioeric.
This patch adds a 'category' extension field to the LSP diagnostic that's sent
by Clangd. This extension is always on by default.
Repository:
