This revision was automatically updated to reflect the committed changes.
Closed by commit rL339787: [AST] Pack the bits of TemplateSpecializationType
into Type (authored by brunoricci, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
riccibruno updated this revision to Diff 160805.
riccibruno added a comment.
update the comment in TemplateSpecializationTypeBitfields
Repository:
rC Clang
https://reviews.llvm.org/D50643
Files:
include/clang/AST/Type.h
lib/AST/Type.cpp
Index: lib/AST/Type.cpp
riccibruno added a comment.
I don't like these bit-field abuses too much but this is
used all over the place in clang and so if this breaks so
many things are going to break.
Repository:
rC Clang
https://reviews.llvm.org/D50643
___
cfe-commits
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Ah, right. I missed that the others already do it. Fine I guess...
Repository:
rC Clang
https://reviews.llvm.org/D50643
___
riccibruno added a comment.
All of these bitfields (ab)use are already UB I think...
I don't see what is special in this case...
Repository:
rC Clang
https://reviews.llvm.org/D50643
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
erichkeane added a comment.
I think that this causes UB. The Type baseclass will use the TypeBitfields
active member, but this uses the TemplateSpecializationTypeBits, right? I know
we take advantage of this elsewhere, but I'm tentative about this one...
Repository:
rC Clang
riccibruno created this revision.
riccibruno added a reviewer: erichkeane.
riccibruno added a project: clang.
Herald added a subscriber: cfe-commits.
Type has enough space for two members of
TemplateSpecializationType. Mechanical patch.
Repository:
rC Clang
https://reviews.llvm.org/D50643
