[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-24 Thread Jonas Toth via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC340623: [clang-format] fix PR38525 - Extraneous continuation indent spaces with… (authored by JonasToth, committed by ). Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/Contin

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-24 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. @JonasToth Yes, please. Also https://reviews.llvm.org/D50697 :) Thanks again for getting me started! Repository: rC Clang https://reviews.llvm.org/D50699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-24 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. Owen, shall i commit for you? Repository: rC Clang https://reviews.llvm.org/D50699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-14 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 160622. owenpan added a comment. Simplified the test case. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ==

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-14 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 160577. owenpan added a comment. Added a test case. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp =

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-14 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 160564. owenpan added a comment. Updated the patch to include lib/Format path prefix. Repository: rC Clang https://reviews.llvm.org/D50699 Files: lib/Format/ContinuationIndenter.cpp Index: lib/Format/ContinuationIndenter.cpp =

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-14 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added a comment. In https://reviews.llvm.org/D50699#1198813, @owenpan wrote: > Updated patch created by "svn diff --diff-cmd=diff -x -U99" The patch seems not to be in the correct path (the `lib/Format` thing is missing). Could you check that again? If you plan to add more patche

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-14 Thread Owen Pan via Phabricator via cfe-commits
owenpan updated this revision to Diff 160561. owenpan added a comment. Updated patch created by "svn diff --diff-cmd=diff -x -U99" Repository: rC Clang https://reviews.llvm.org/D50699 Files: ContinuationIndenter.cpp Index: ContinuationIndenter.cpp

[PATCH] D50699: [clang-format] fix PR38525 - Extraneous continuation indent spaces with BreakBeforeBinaryOperators set to All

2018-08-14 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya added a comment. In https://reviews.llvm.org/D50699#1198770, @owenpan wrote: > Test case: > F6937162: BreakBeforeBinaryOperators.cpp Please add a testcase in the source and add checks to verify the changes. Repository: rC Clang https://reviews