v.g.vassilev added a comment.
@hamzasood, I suppose this is still worth pursuing. Could you address the
comment?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D50763/new/
https://reviews.llvm.org/D50763
___
cfe-commits
rsmith added inline comments.
Herald added a project: clang.
Comment at: lib/Parse/ParseCXXInlineMethods.cpp:266
+public:
+ UseCachedTokensRAII(Parser &Self, CachedTokens &Cache, const void *Data)
+ : Self(Self), Data(Data) {
Can you pass ownership of the c
hamzasood created this revision.
hamzasood added reviewers: erichkeane, v.g.vassilev, malcolm.parsons, rsmith.
Herald added a reviewer: javed.absar.
Herald added subscribers: cfe-commits, kristof.beyls, eraman.
This patch extracts the eof/stop token pattern used in late-parsing to a
re-usable RAI