[PATCH] D51041: [clang-tidy] Don't run misc-unused-using-decls check in C++17.

2018-09-24 Thread Jonas Toth via Phabricator via cfe-commits
JonasToth added inline comments. Comment at: test/clang-tidy/misc-unused-using-decls-cxx17.cpp:1 +// RUN: %check_clang_tidy %s misc-unused-using-decls %t -- -- -fno-delayed-template-parsing -std=gnu++17 + why gnu++17 and not standard? Repository: rCTE Clang

[PATCH] D51041: [clang-tidy] Don't run misc-unused-using-decls check in C++17.

2018-08-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:35 + // it is not ture in C++17's template argument deduction. + if (!getLangOpts().CPlusPlus || getLangOpts().CPlusPlus17 || +

[PATCH] D51041: [clang-tidy] Don't run misc-unused-using-decls check in C++17.

2018-08-22 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 161893. hokein added a comment. Remove redundant CPlusPlus2a. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51041 Files: clang-tidy/misc/UnusedUsingDeclsCheck.cpp test/clang-tidy/misc-unused-using-decls-cxx17.cpp Index:

[PATCH] D51041: [clang-tidy] Don't run misc-unused-using-decls check in C++17.

2018-08-21 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang-tidy/misc/UnusedUsingDeclsCheck.cpp:35 + // it is not ture in C++17's template argument deduction. + if (!getLangOpts().CPlusPlus || getLangOpts().CPlusPlus17 || + getLangOpts().CPlusPlus2a) Isn't the

[PATCH] D51041: [clang-tidy] Don't run misc-unused-using-decls check in C++17.

2018-08-21 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added a subscriber: xazax.hun. It introduces some false positives which are non-trivial to fix. Ignore running the check in C++17. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D51041 Files: